Vault7: CIA Hacking Tools Revealed
Navigation: » Latest version
Owner: User #524297
Code Review
THOU MUST
- Read code at your own workstation
-
If your code is being reviewed: Address all provided comments.
- It takes a lot of time to read and understand code, so you should respectfully respond to all comments.
- If you are reviewing code: Take the time to understand it fully, and provide commentary.
THOU SHOULD
-
Use available tools (i.e. Stash pull requests) to make this communication easier
- Configure Stash to Enforce Workflows and Pull Requests
- Configure Stash to Enforce Workflows and Pull Requests
- Clone, build and run (if you can't do this easily, this is a problem)
- Provide constructive comments
- Review in small logical chunks of code (a source file or module, small commits lead to faster and easier code reviews)
THOU SHOULD NOT
- Skim code superficially and blindly click 'Accept'
- Read code on a projector in a conference room (zzzzzz...)
-
Make code style comments just to start a flame war
THOU MUST NOT
-
Conduct a Code Review after a project has already been delivered to IV&V. (What's the point? You can't incorporate any recommendations, and you'll bore everyone walking through the entire codebase!)