Vault7: CIA Hacking Tools Revealed
Navigation: » Latest version
Owner: User #524297
Code Review
THOU MUST
- read code at your workstation
- use stash pull-request
-
address all provided comments
- it takes alot of time to read your code. you should respond to all comments.
THOU SHOULD
- build and run
- provide constructive comments
- review in small logical chunks of code (a source file or module)
THOU SHOULD NOT
- Skim
-
Read code on a projector in a conference room
THOU MUST NOT
-
Conduct a Code Review after a project has already been delivered to IV&V. (What's the point? You can't incorporate recommendations, and you'll bore everyone walking through the entire codebase!)